On Thu, Oct 23, 2014 at 4:21 PM, Eric Dumazet [off-list ref] wrote:

On Thu, 2014-10-23 at 02:58 -0400, Jonathan Toppins wrote:

quoted

quoted

+           if (!pool) {
+                   pool = kzalloc_node(sizeof(*pool), GFP_KERNEL,

GFP_DMA | GFP_KERNEL
This memory will possibly be used in a DMA correct? (thinking crypto
hardware offload)

I am not sure this is the case, but this certainly can be added.

As far as I know what GFP_DMA actually does is restrict allocation to
low memory addresses under 24 bits for very old devices. There is also
GFP_DMA32 which restricts to addresses under 32 bytes (for device
which don't support 64 bit addresses).

This kind of stuff only belongs in device drivers where the exact
hardware limitations are known. I don't think crypto devices with this
kind of limitations can be exposed through the crypto API that the
md5sig feature uses.

--
Regards,
Leonard