Thread (11 messages) 11 messages, 2 authors, 2014-09-15

Re: [PATCH v3 5/9] net: pxa168_eth: get and set the mac address on the Ethernet controller

From: David Miller <davem@davemloft.net>
Date: 2014-09-15 19:35:54
Also in: linux-arm-kernel, linux-devicetree, lkml

From: Antoine Tenart <redacted>
Date: Mon, 15 Sep 2014 16:01:49 +0200
+static void pxa168_eth_get_mac_address(struct net_device *dev,
+				       unsigned char *addr)
+{
+	struct pxa168_eth_private *pep = netdev_priv(dev);
+	unsigned int mac_h = rdl(pep, MAC_ADDR_HIGH);
+	unsigned int mac_l = rdl(pep, MAC_ADDR_LOW);
+
+	addr[0] = (mac_h >> 24) & 0xff;
+	addr[1] = (mac_h >> 16) & 0xff;
+	addr[2] = (mac_h >> 8) & 0xff;
+	addr[3] = mac_h & 0xff;
+	addr[4] = (mac_l >> 8) & 0xff;
+	addr[5] = mac_l & 0xff;
+}
This function is not used in this patch and thus will result in a compile
warning.

The tree must be fully functional and compile with no new warnings after
each patch in a patch series.

Therefore you must add this new function in the first patch which actually
makes use of the new function.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help