On Tue, Sep 30, 2014 at 7:49 AM, Eric Dumazet [off-list ref] wrote:

On Tue, 2014-09-30 at 07:26 -0700, Tom Herbert wrote:

quoted

Yes, this is the wrong place to put it. DQL knows nothing about
packets or technically even bytes, it's a generic library that deal
with "objects" on a queue. I don't see how burst relates to this.

I wonder then why you put :

netdev_tx_completed_queue(struct netdev_queue *dev_queue,
                          unsigned int pkts, unsigned int bytes)

In case we ever wanted to count by packets instead of or in addition to bytes.

Really, I don't care _where_ the attribute is, as long we dont access
yet another cache line in fast path.

Just put it after/before dql in netdev_queue structure.