Re: [net-next PATCH 1/1 V4] qdisc: bulk dequeue support for qdiscs with TCQ_F_ONETXQUEUE
From: Eric Dumazet <hidden>
Date: 2014-09-24 19:22:25
From: Eric Dumazet <hidden>
Date: 2014-09-24 19:22:25
On Wed, 2014-09-24 at 11:34 -0700, Tom Herbert wrote:
quoted
I believe drivers typically use skb->len for BQL tracking. Since bytelimit is based on BQL here, it might be more correct to use skb->len.
That is only because drivers dont have access to qdisc_pkt_len(skb) as : - We can call them without any qdisc traversal - We escaped from qdisc layer, and gso packet do not have the field set And drivers actually update BQL inflight, while bulk dequeue do not update it (its a local copy) I do not particularly care, as BQL do not have to be 100% precise.