Thread (11 messages) flat view 11 messages, 5 authors, 2014-09-08

Re: [PATCH 1/3] virtio_net: pass well-formed sgs to virtqueue_add_*()

From: Andy Lutomirski <luto@amacapital.net>
Date: 2014-09-03 04:54:34

On Tue, Sep 2, 2014 at 9:29 PM, Rusty Russell [off-list ref] wrote:
This is the only driver which doesn't hand virtqueue_add_inbuf and
virtqueue_add_outbuf a well-formed, well-terminated sg.  Fix it,
so we can make virtio_add_* simpler.
OK, I get it now: you're reinitializing the table every time, clearing
old end marks.  There's room to microoptimize this, but it's probably
not worth it.

IOW, looks good to me.

--Andy
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help