Re: [PATCH 0/2] Get rid of ndo_xmit_flush
From: Rusty Russell <hidden>
Date: 2014-09-01 01:31:26
Jesper Dangaard Brouer [off-list ref] writes:
On Tue, 26 Aug 2014 08:28:15 +0200 Jesper Dangaard Brouer [off-list ref] wrote:quoted
On Mon, 25 Aug 2014 16:34:58 -0700 (PDT) David Miller [off-list ref] wrote:quoted
Given Jesper's performance numbers, it's not the way to go. Instead, go with a signalling scheme via new boolean skb->xmit_more.I'll do benchmarking based on this new API proposal today.While establish an accurate baseline for my measurements. I'm starting to see too much variation in my trafgen measurements. Meaning that we unfortunately cannot use it to measure variations on the nanosec scale. I'm measuring the packets per sec via "ifpps", and calculating an average over the measurements, via the following oneliner: $ ifpps -clod eth5 -t 1000 | awk 'BEGIN{txsum=0; rxsum=0; n=0} /[[:digit:]]/ {txsum+=$11;rxsum+=$3;n++; printf "instant rx:%u tx:%u pps n:%u average: rx:%d tx:%d pps\n", $3, $11, n, rxsum/n, txsum/n }'
FYI, this is what I use for this kind of thing:
https://github.com/rustyrussell/stats
From the README:
This filter finds identical lines and collapses all the numbers into a range, average and standard deviation; it can also print out all the numbers in CSV form for import into spreadsheets, etc. Cheers, Rusty.