Re: [PATCH 0/2] Get rid of ndo_xmit_flush
From: David Miller <davem@davemloft.net>
Date: 2014-08-27 20:48:07
From: David Miller <davem@davemloft.net>
Date: 2014-08-27 20:48:07
From: Jesper Dangaard Brouer <redacted> Date: Wed, 27 Aug 2014 15:56:51 +0200
I do worry a bit, if writing skb->xmit_more in a more cache cold scenarios could hurt us (as that cacheline seems to be read mostly), but this is not a problem right now because it will always be cache hot, as we always clear the entire SKB in alloc.
And as I mentioned to Eric, xmit_more sits right next to the queue number which is also dirtied in the TX path.