Thread (13 messages) 13 messages, 4 authors, 2014-08-06

Re: [PATCH net-next 0/3] Make is_kdump_kernel() accessible from modules

From: Vivek Goyal <vgoyal@redhat.com>
Date: 2014-08-01 12:44:41

On Thu, Jul 31, 2014 at 12:22:44PM -0700, David Miller wrote:
From: Vivek Goyal <vgoyal@redhat.com>
Date: Thu, 31 Jul 2014 09:07:56 -0400
quoted
If there are performance implications of low memory profile, then user
needs to live with it. Otherwise they should not use low_memory_env
boot option to begin with.
I personally think we should avoid changing scripts, by having a kdump
kernel force this low_mem profile to be true.
If we go with current implementation, we don't have to change any of the
existing scripts.  Current implementation enforces low mem profile in
drivers for kdump kernel.

I am growing more skeptical of suggested low_mem_env boot option as there
will be contention that for different amount of low memory there should
be different profiles. One might argue that for 256MB use one kind of
profile while same profile might not be best fit for 2G of memory.

So instead of venturing into too generic option, I am fine with sticking
to a more custom option which works for kdump use case (is_kdump_kernel()).

So I would like to ack this patch series in current form.

Acked-by: Vivek Goyal <vgoyal@redhat.com>

Thanks
Vivek
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help