Thread (13 messages) 13 messages, 4 authors, 2014-08-06

Re: [PATCH net-next 0/3] Make is_kdump_kernel() accessible from modules

From: Vivek Goyal <vgoyal@redhat.com>
Date: 2014-07-30 12:35:38

On Tue, Jul 29, 2014 at 04:46:32PM -0700, David Miller wrote:
From: Vivek Goyal <vgoyal@redhat.com>
Date: Mon, 28 Jul 2014 08:26:09 -0400
quoted
On Sun, Jul 27, 2014 at 05:48:32PM -0700, Andi Kleen wrote:
quoted
Amir Vadai [off-list ref] writes:
quoted
Hi,

I'm sending this patchset to net-next because it touches a commit [1] that was
applied lately to net-next.
It would be better to have a generic function for "run with small
memory", that can be also triggered in other ways, e.g. a sysctl or
a boot opion, with kdump just another user.

There are low memory cases which are not kdump.
I am fine with a boot option to suggest low memory profile and kdump
scripts can be modified to automatically append that command line option
to second kernel.
I'm therefore going to assume that this patch series will be updated when the
new facility is added.
Hi Amir,

Can you please add a new kernel parameter say, "low_memory_env" and change
rest of the patches to make use of this kernel parameter and repost.

I think for the drivers who were using "reset_devices" to switch to low
memory profile, you will have to retain that otherwise new kernel will
be broken with old kexec-tools/scripts which don't know that a new
parameter "low_memory_env" needs to be passed. 

May be we can do following.

/* TODO: Get rid of dependency on reset_devices after some time */
if (low_memory_env || reset_devices)
	use_low_memory_profile;

Thanks
Vivek
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help