On 08/01/2014 05:05 AM, Hannes Frederic Sowa wrote:

On Do, 2014-07-31 at 17:54 +0800, Duan Jiong wrote:

quoted

When dealing with ICMPv[46] Error Message, function icmp_socket_deliver()
and icmpv6_notify() do some valid checks on packet's length, but then some
protocols check packet's length redaudantly. So remove those duplicated
statements, and increase counter ICMP_MIB_INERRORS/ICMP6_MIB_INERRORS in
function icmp_socket_deliver() and icmpv6_notify() respectively.

In addition, add missed counter in udp6/udplite6 when socket is NULL.

Signed-off-by: Duan Jiong <redacted>
---

v2: remove nested rcu_read_lock from icmpv6_notify

Acked-by: Hannes Frederic Sowa <redacted>

IPv4 handler can also be cleaned up. ;)

Ok, i will make another patch soon. :)

Thanks,
  Duan

Thanks!