Re: [PATCH v2] net: fix the counter ICMP_MIB_INERRORS/ICMP6_MIB_INERRORS
From: Hannes Frederic Sowa <hidden>
Date: 2014-07-31 21:05:31
From: Hannes Frederic Sowa <hidden>
Date: 2014-07-31 21:05:31
On Do, 2014-07-31 at 17:54 +0800, Duan Jiong wrote:
When dealing with ICMPv[46] Error Message, function icmp_socket_deliver() and icmpv6_notify() do some valid checks on packet's length, but then some protocols check packet's length redaudantly. So remove those duplicated statements, and increase counter ICMP_MIB_INERRORS/ICMP6_MIB_INERRORS in function icmp_socket_deliver() and icmpv6_notify() respectively. In addition, add missed counter in udp6/udplite6 when socket is NULL. Signed-off-by: Duan Jiong <redacted> --- v2: remove nested rcu_read_lock from icmpv6_notify
Acked-by: Hannes Frederic Sowa <redacted> IPv4 handler can also be cleaned up. ;) Thanks!