Thread (55 messages) 55 messages, 10 authors, 2014-07-16

Re: [PATCH v7 29/33] net: brcmfmac - set name assign type

From: Tom Gundersen <hidden>
Date: 2014-07-15 19:57:58
Also in: linux-wireless, lkml

On Tue, Jul 15, 2014 at 9:39 PM, John W. Linville
[off-list ref] wrote:
I don't seem to have a line with "NET_NAME_UNKNOWN" in this driver
in any of my kernel trees.  What tree are you using for development?
This was patch part of the series introducing NET_NAME_UNKNOWN [0].
I'll resubmit this patch once the earlier patches introducing the
infrastructure have been applied.

Cheers,

Tom

[0]: <https://lkml.org/lkml/2014/7/10/94>.
On Thu, Jul 10, 2014 at 10:17:34AM +0200, Tom Gundersen wrote:
quoted
The name is given by the firmware, so we assume it is predictable.

Signed-off-by: Tom Gundersen <redacted>
Cc: Brett Rudley <brudley-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
Cc: Arend van Spriel <arend-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
Cc: "Franky (Zhenhui) Lin" <frankyl-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
Cc: Hante Meuleman <meuleman-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
Cc: John Linville <redacted>
Cc: linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: brcm80211-dev-list-dY08KVG/lbpWk0Htik3J/w@public.gmane.org
---
 drivers/net/wireless/brcm80211/brcmfmac/fweh.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/brcm80211/brcmfmac/fweh.c b/drivers/net/wireless/brcm80211/brcmfmac/fweh.c
index f6990f2..8d32721 100644
--- a/drivers/net/wireless/brcm80211/brcmfmac/fweh.c
+++ b/drivers/net/wireless/brcm80211/brcmfmac/fweh.c
@@ -201,7 +201,8 @@ static void brcmf_fweh_handle_if_event(struct brcmf_pub *drvr,
              brcmf_dbg(EVENT, "adding %s (%pM)\n", emsg->ifname,
                        emsg->addr);
              ifp = brcmf_add_if(drvr, ifevent->bssidx, ifevent->ifidx,
-                                emsg->ifname, NET_NAME_UNKNOWN, emsg->addr);
+                                emsg->ifname, NET_NAME_PREDICTABLE,
+                                emsg->addr);
              if (IS_ERR(ifp))
                      return;
              brcmf_fws_add_interface(ifp);
--
1.9.3
--
John W. Linville                Someday the world will need a hero, and you
linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org                  might be all we have.  Be ready.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help