Re: [PATCH v7 29/33] net: brcmfmac - set name assign type
From: Arend van Spriel <hidden>
Date: 2014-07-10 20:08:23
Also in:
linux-wireless, lkml
On 10-07-14 10:17, Tom Gundersen wrote:
The name is given by the firmware, so we assume it is predictable.
How about the scenario where one would have multiple broadcom wifi devices in the system. Both driver instances would alloc_netdev with predictable but also the same ifname. Wondering whether we should ignore the firmware ifname altogether. Regards, Arend
quoted hunk ↗ jump to hunk
Signed-off-by: Tom Gundersen <redacted> Cc: Brett Rudley <redacted> Cc: Arend van Spriel <redacted> Cc: "Franky (Zhenhui) Lin" <redacted> Cc: Hante Meuleman <redacted> Cc: John Linville <redacted> Cc: linux-wireless@vger.kernel.org Cc: brcm80211-dev-list@broadcom.com --- drivers/net/wireless/brcm80211/brcmfmac/fweh.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)diff --git a/drivers/net/wireless/brcm80211/brcmfmac/fweh.c b/drivers/net/wireless/brcm80211/brcmfmac/fweh.c index f6990f2..8d32721 100644 --- a/drivers/net/wireless/brcm80211/brcmfmac/fweh.c +++ b/drivers/net/wireless/brcm80211/brcmfmac/fweh.c@@ -201,7 +201,8 @@ static void brcmf_fweh_handle_if_event(struct brcmf_pub *drvr, brcmf_dbg(EVENT, "adding %s (%pM)\n", emsg->ifname, emsg->addr); ifp = brcmf_add_if(drvr, ifevent->bssidx, ifevent->ifidx, - emsg->ifname, NET_NAME_UNKNOWN, emsg->addr); + emsg->ifname, NET_NAME_PREDICTABLE, + emsg->addr); if (IS_ERR(ifp)) return; brcmf_fws_add_interface(ifp);