Thread (41 messages) 41 messages, 7 authors, 2014-07-25

Re: [PATCH] ipv4: fix a race in ip4_datagram_release_cb()

From: Eric Dumazet <hidden>
Date: 2014-06-30 06:38:18

On Sat, 2014-06-28 at 17:25 -0700, dormando wrote:
On Tue, 10 Jun 2014, Eric Dumazet wrote:
quoted
On Tue, 2014-06-10 at 18:12 -0700, Eric Dumazet wrote:
quoted
For the curious, another problem is in ipv4_sk_update_pmtu()

This can be called on UDP sockets, but from softirq context.

We cannot use sk_dst_lock because this lock is not softirq safe.

I guess we should use xchg() for sk_dst_set() and sk_dst_reset()
This would be something like this untested patch :
I see this didn't get queued for stable, should it be dropped due to the
later patch? (which did get queued for stable).
I have this patch in my queue.

I have to submit it officially before it can be merged...

David seems quite busy these days anyway.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help