Re: [PATCH] ipv4: fix a race in ip4_datagram_release_cb()
From: dormando <hidden>
Date: 2014-06-22 19:07:25
On Wed, 11 Jun 2014, Eric Dumazet wrote:
On Wed, 2014-06-11 at 18:55 -0700, dormando wrote:quoted
I sent the udpkill utility in an off-list mail (in case that got binned by anyone). Just threw this patch on top of the other two, on 3.10.42. udpkill's been running for an hour without fault. I've just put traffic back onto the machine am leaving udpkill enabled for a while longer. So, this is an improvement :)Nice. I suspect regression came with 3.6 ip route cache removal, but I am lazy to point the exact commit.
Update on testing: I only have two machines that crash on their own frequently (more like one, even). Unfortunately something happened to the datacenter it's in and it was offline for a week. The machine normally crashes after 1.5-4d, averaging 2d. It's done about three days total time without a new crash. I also have the kernel running in another datacenter for ~10 days.. but it takes 30-150 days to crash in that one. So, inconclusive, but still promising. If the machine survives the week it probably means it's fixed, or at least greatly reduced. I saw that one of your patches got queued for stable, but all three were necessary to fix udpkill. What's your plan for cleanup/upstreaming? Did you folks end up running udpkill under the tester thing? thanks, -Dormando