[PATCH 04/17] MIPS: bpf: Use the LO register to get division's quotient
From: Markos Chandras <hidden>
Date: 2014-06-23 09:39:28
Also in:
linux-mips
Subsystem:
bpf jit for mips (32-bit and 64-bit), bpf [general] (safe dynamic programs and tools), mips, the rest · Maintainers:
Johan Almbladh, Paul Burton, Alexei Starovoitov, Daniel Borkmann, Andrii Nakryiko, Eduard Zingerman, Kumar Kartikeya Dwivedi, Thomas Bogendoerfer, Linus Torvalds
Reading from the HI register to get the division result is wrong. The quotient is placed in the LO register. Cc: "David S. Miller" <davem@davemloft.net> Cc: Daniel Borkmann <redacted> Cc: Alexei Starovoitov <redacted> Cc: netdev@vger.kernel.org Signed-off-by: Markos Chandras <redacted> --- arch/mips/net/bpf_jit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/net/bpf_jit.c b/arch/mips/net/bpf_jit.c
index f7c206404989..5cc92c4590cb 100644
--- a/arch/mips/net/bpf_jit.c
+++ b/arch/mips/net/bpf_jit.c@@ -408,7 +408,7 @@ static inline void emit_div(unsigned int dst, unsigned int src, u32 *p = &ctx->target[ctx->idx]; uasm_i_divu(&p, dst, src); p = &ctx->target[ctx->idx + 1]; - uasm_i_mfhi(&p, dst); + uasm_i_mflo(&p, dst); } ctx->idx += 2; /* 2 insts */ }
--
2.0.0