Thread (15 messages) flat view 15 messages, 6 authors, 2014-06-09

Re: [PATCH net-next] net: force a list_del() in unregister_netdevice_many()

From: Eric Dumazet <hidden>
Date: 2014-06-09 05:48:03

On Mon, 2014-06-09 at 09:27 +0800, Gao feng wrote:
On 06/06/2014 09:44 PM, Eric Dumazet wrote:
quoted
From: Eric Dumazet <edumazet@google.com>

unregister_netdevice_many() API is error prone and we had too
many bugs because of dangling LIST_HEAD on stacks.

See commit f87e6f47933e3e ("net: dont leave active on stack LIST_HEAD")

In fact, instead of making sure no caller leaves an active list_head,
just force a list_del() in the callee. No one seems to need to access
the list after unregister_netdevice_many()
Just like the patch I posted one year ago, interesting :)
http://patchwork.ozlabs.org/patch/223521/

Yeah, apparently no caller has to keep around the list in current
kernel. Not sure how it was last year.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help