Re: [PATCH net-next] net: force a list_del() in unregister_netdevice_many()
From: David Miller <davem@davemloft.net>
Date: 2014-06-08 21:15:32
From: Eric Dumazet <redacted> Date: Fri, 06 Jun 2014 06:44:03 -0700
From: Eric Dumazet <edumazet@google.com>
unregister_netdevice_many() API is error prone and we had too
many bugs because of dangling LIST_HEAD on stacks.
See commit f87e6f47933e3e ("net: dont leave active on stack LIST_HEAD")
In fact, instead of making sure no caller leaves an active list_head,
just force a list_del() in the callee. No one seems to need to access
the list after unregister_netdevice_many()
Signed-off-by: Eric Dumazet <edumazet@google.com>
---
I based this patch on net-next, but it seems to close existing bugs,
so its probably a stable candidate.It applied cleanly to net so I applied it there and will queue up for -stable, thanks.