RE: [PATCH v2 0/6] net: fec: Enable Software TSO to improve the tx performance

Hi, David,

From: David Miller <davem@davemloft.net> Data: Thursday, June 05, 2014 6:29 AM

To: Duan Fugang-B38611
Cc: netdev@vger.kernel.org; shawn.guo@linaro.org; Estevam Fabio-R49496;
ezequiel.garcia@free-electrons.com; bhutchings@solarflare.com;
stephen@networkplumber.org; Li Frank-B20596; David.Laight@ACULAB.COM;
eric.dumazet@gmail.com
Subject: Re: [PATCH v2 0/6] net: fec: Enable Software TSO to improve the tx
performance


I think you need to start taking David Laight's feedback more seriously.

He's right, it makes no sense at all the increase the number of RX
descriptors for the sake of a send side feature like TSO.

If you have a another reason to increase the RX descriptor count, do it as
a separate change and with an appropriate commit log message explaining WHY
you are doing this.

I'm not applying this patch series until you start taking the feedback you
are receiving to heart.

Considering with David Laight's suggestion by previous mail, I decide to remove the RX descriptors number change for the patch set.
After the patch set, I have another patch serial for new feature support like interrupt coalescing that request
RX descriptors number is enough big.  I will generate one separate patch to increase RX BDs entry.

I will send the V3 for the change.

Thanks,
Andy