RE: [PATCH v2 4/6] net: fec: Increase buffer descriptor entry number

From: David Laight <redacted> Data: Wednesday, June 04, 2014 5:27 PM

To: Duan Fugang-B38611; davem@davemloft.net
Cc: netdev@vger.kernel.org; shawn.guo@linaro.org; Estevam Fabio-R49496;
ezequiel.garcia@free-electrons.com; bhutchings@solarflare.com;
stephen@networkplumber.org; Li Frank-B20596; eric.dumazet@gmail.com
Subject: RE: [PATCH v2 4/6] net: fec: Increase buffer descriptor entry
number

From: Fugang Duan

quoted

In order to support SG, software TSO, let's increase BD entry number.

CC: Ezequiel Garcia <redacted>
CC: Eric Dumazet <redacted>
CC: David Laight <redacted>
Signed-off-by: Fugang Duan <redacted>
---
 drivers/net/ethernet/freescale/fec.h      |    6 +++---
 drivers/net/ethernet/freescale/fec_main.c |   21 ++++++++++++-------

--

quoted

 2 files changed, 15 insertions(+), 12 deletions(-)

diff --git a/drivers/net/ethernet/freescale/fec.h

b/drivers/net/ethernet/freescale/fec.h

quoted

index 3b8d6d1..798ad88 100644

--- a/drivers/net/ethernet/freescale/fec.h
+++ b/drivers/net/ethernet/freescale/fec.h

@@ -240,14 +240,14 @@ struct bufdesc_ex {
  * the skbuffer directly.
  */

-#define FEC_ENET_RX_PAGES	8
+#define FEC_ENET_RX_PAGES	128
 #define FEC_ENET_RX_FRSIZE	2048
 #define FEC_ENET_RX_FRPPG	(PAGE_SIZE / FEC_ENET_RX_FRSIZE)
 #define RX_RING_SIZE		(FEC_ENET_RX_FRPPG * FEC_ENET_RX_PAGES)

...

You are changing the number of rx descriptors as well.
This isn't mentioned in the description.

And, as I said before, basing this on PAGE_SIZE cannot be right.

	David

The patch just increase tx and rx BD entry number,  and from previous discuss, we set tx number to 512, rx number to 256.


Thanks,
Andy