Re: [PATCH 5/9] tlan: Restart autonegotiation on link loss
From: Sergei Shtylyov <hidden>
Date: 2014-05-28 14:08:11
Also in:
lkml
Hello. On 05/28/2014 01:38 AM, Ondrej Zary wrote:
When link is lost on a card which uses internal PHY for 10 Mbit speeds, restart autonegotiation to allow switching between 10 and 100 Mbps speeds.
Signed-off-by: Ondrej Zary <redacted> --- drivers/net/ethernet/ti/tlan.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+)
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/ethernet/ti/tlan.c b/drivers/net/ethernet/ti/tlan.c index 31d4a96..1047b3f 100644 --- a/drivers/net/ethernet/ti/tlan.c +++ b/drivers/net/ethernet/ti/tlan.c
[...]
quoted hunk ↗ jump to hunk
@@ -2788,6 +2789,19 @@ static void tlan_phy_monitor(unsigned long data) dev->name); tlan_dio_write8(dev->base_addr, TLAN_LED_REG, 0); netif_carrier_off(dev); + if (priv->adapter->flags & TLAN_ADAPTER_USE_INTERN_10) { + /* power down internal PHY */ + u16 data = MII_GC_PDOWN | MII_GC_LOOPBK + | MII_GC_ISOLATE;
Please, leave | on the previosu line.
+ tlan_mii_sync(dev->base_addr); + tlan_mii_write_reg(dev, priv->phy[0], + MII_GEN_CTL, data);
Please start this line right under 'dev' on the previous one.
+ /* set to external PHY */ + priv->phy_num = 1; + /* restart autonegotiation */ + tlan_set_timer(dev, (4*HZ/10), TLAN_TIMER_PHY_PDOWN);
Spaces around * and / wouldn't hurt for consistency.
+ return; + } } }
WBR, Sergei