Re: rfc: checkpatch logical line continuations (was IBM Akebono: Add support for a new PHY interface to the IBM emac driver)
From: Dan Carpenter <hidden>
Date: 2014-03-07 23:05:01
Also in:
linux-devicetree, linuxppc-dev, lkml
On Fri, Mar 07, 2014 at 01:30:17PM -0800, josh-iaAMLnmF4UmaiuxdJuQwMA@public.gmane.org wrote:
On Fri, Mar 07, 2014 at 01:02:44PM -0800, Joe Perches wrote:quoted
On Fri, 2014-03-07 at 15:41 -0500, David Miller wrote:quoted
From: Alistair Popple <redacted> Date: Thu, 6 Mar 2014 14:52:25 +1100quoted
+ out_be32(dev->reg, in_be32(dev->reg) | WKUP_ETH_RGMIIEN + | WKUP_ETH_TX_OE | WKUP_ETH_RX_IE);When an expression spans multiple lines, the lines should end with operators rather than begin with them.That's not in CodingStyle currently.It's also not even remotely consistent across existing kernel code, and it isn't obvious that there's a general developer consensus on the "right" way to write it.
We just had this discussion in staging and Greg modified the patch to put the operator at the end. https://lkml.org/lkml/2014/2/25/125 It's like logical && and || operators which go at the end these days. I don't really want to have a lot of checkpatch churn to convert everything... regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html