Thread (12 messages) 12 messages, 6 authors, 2014-05-02

Re: [PATCH 2/5] IBM Akebono: Add support for a new PHY interface to the IBM emac driver

From: David Miller <hidden>
Date: 2014-03-07 20:41:47
Also in: linux-devicetree, linuxppc-dev, lkml

From: Alistair Popple <redacted>
Date: Thu,  6 Mar 2014 14:52:25 +1100
+	out_be32(dev->reg, in_be32(dev->reg) | WKUP_ETH_RGMIIEN
+		 | WKUP_ETH_TX_OE | WKUP_ETH_RX_IE);
When an expression spans multiple lines, the lines should end with
operators rather than begin with them.

Also, it would be easier to read this call if parenthesis were put
around the third argument and then indented to match, f.e.:

	out_be32(dev->reg, (in_be32(dev->reg) | WKUP_ETH_RGMIIEN |
			    WKUP_ETH_TX_OE | WKUP_ETH_RX_IE));
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help