On Mon, Mar 31, 2014 at 9:40 AM, Eric Dumazet [off-list ref] wrote:

On Mon, 2014-03-31 at 09:27 -0700, Jay Vosburgh wrote:

quoted

Eric Dumazet [off-list ref] wrote:

quoted

On Fri, 2014-03-28 at 22:29 -0700, Mahesh Bandewar wrote:

quoted

micro change to initialize / cancel the ALB work queue only
if the mode selected is ALB or TLB.

Signed-off-by: Mahesh Bandewar <redacted>
---

Can the mode of a bonding device be dynamically changed ?

      No.  The mode can only be changed when there are no slaves in
the bond, and the bond is administratively down.

I don't see why this patch is needed.

What about mii_work, arp_work ?

I was focusing on the lb mode only at this time.

There is no cost calling INIT_DELAYED_WORK(&bond->alb_work,
bond_alb_monitor) and cancel_delayed_work_sync(&bond->alb_work)

Why even bother initialize if we know *for sure* we are not going to
use it. In subsequent patch though the work queue may or may not be
needed based on the tlb_dynamic_mode selected. That's when I though we
should *only* enabled it in the mode that is relevant.