Re: [PATCH 3/5] bonding: Initialize the ALB work queue for lb mode only.
From: Eric Dumazet <hidden>
Date: 2014-03-31 16:40:42
From: Eric Dumazet <hidden>
Date: 2014-03-31 16:40:42
On Mon, 2014-03-31 at 09:27 -0700, Jay Vosburgh wrote:
Eric Dumazet [off-list ref] wrote:quoted
On Fri, 2014-03-28 at 22:29 -0700, Mahesh Bandewar wrote:quoted
micro change to initialize / cancel the ALB work queue only if the mode selected is ALB or TLB. Signed-off-by: Mahesh Bandewar <redacted> ---Can the mode of a bonding device be dynamically changed ?No. The mode can only be changed when there are no slaves in the bond, and the bond is administratively down.
I don't see why this patch is needed. What about mii_work, arp_work ? There is no cost calling INIT_DELAYED_WORK(&bond->alb_work, bond_alb_monitor) and cancel_delayed_work_sync(&bond->alb_work)