Thread (11 messages) 11 messages, 6 authors, 2014-04-01

Re: [PATCH net-next] net/mlx4_core: Handle null return by pci_match_id()

From: David Miller <davem@davemloft.net>
Date: 2014-03-31 20:32:43

From: Wei Yang <redacted>
Date: Mon, 31 Mar 2014 11:54:39 +0800
On Sun, Mar 30, 2014 at 09:08:06PM +0300, Or Gerlitz wrote:
quoted
On Sun, Mar 30, 2014 at 6:26 PM, Amir Vadai [off-list ref] wrote:
quoted
Fix issue introduced by commit: 97a5221 "net/mlx4_core: pass
pci_device_id.driver_data to __mlx4_init_one during reset".

pci_match_id() might return NULL if someone binds the driver to a device
manually using /sys/bus/pci/drivers/.../new_id. Need to check 'id'
before using it.

Thanks to Bjorn who raised the problem.
Well, that commit was applied to net and is now present in Linus
tree... so assuming it's too late for 3.14, need to queue this for
-stable

Or.
Sorry for this bothering, hope this will not block someone.

Here is my suggestion for fixing this, not sure this is a good way to export
pci_match_device() to modules. This is my current solution to this problem. If
you have any comments, please let me know.
This needs to be ACK'd by the PCI maintainers, please make sure they see this.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help