On Mon, Mar 31, 2014 at 07:52:20AM +0300, Or Gerlitz wrote:

On Mon, Mar 31, 2014 at 6:54 AM, Wei Yang [off-list ref] wrote:

quoted

On Sun, Mar 30, 2014 at 09:08:06PM +0300, Or Gerlitz wrote:

quoted

On Sun, Mar 30, 2014 at 6:26 PM, Amir Vadai [off-list ref] wrote:

quoted

Fix issue introduced by commit: 97a5221 "net/mlx4_core: pass
pci_device_id.driver_data to __mlx4_init_one during reset".

pci_match_id() might return NULL if someone binds the driver to a device
manually using /sys/bus/pci/drivers/.../new_id. Need to check 'id'
before using it.

Thanks to Bjorn who raised the problem.

Well, that commit was applied to net and is now present in Linus
tree... so assuming it's too late for 3.14, need to queue this for
-stable

Or.

Sorry for this bothering, hope this will not block someone.

Here is my suggestion for fixing this, not sure this is a good way to export
pci_match_device() to modules. This is my current solution to this problem. If
you have any comments, please let me know.

------------------------------------------------------------------------------
From 9361e1edd6776202c6e11dd44d3d4d72c990b111 Mon Sep 17 00:00:00 2001
From: Wei Yang <redacted>
Date: Mon, 31 Mar 2014 11:34:57 +0800
Subject: [PATCH net-next] net/mlx4_core: match pci_device_id including dynids

Your original commit went to net and same needs to be done for the fix

Thanks, seems I still misunderstand this rule.
I thought Amir is correct, so copyed his.

Will pay attention next time.

-- 
Richard Yang
Help you, Help me