From: wangyufen <redacted>
Date: Fri, 28 Mar 2014 17:33:54 +0800

On 2014/3/28 13:47, Joe Perches wrote:

quoted

On Fri, 2014-03-28 at 01:40 -0400, David Miller wrote:

quoted

From: Joe Perches <joe@perches.com>
Date: Thu, 27 Mar 2014 21:22:01 -0700

quoted

On Fri, 2014-03-28 at 12:07 +0800, Wangyufen wrote:
[]

quoted

diff --git a/net/ipv6/ip6_fib.c b/net/ipv6/ip6_fib.c

[]

quoted

@@ -143,7 +143,7 @@ static __inline__ __be32 addr_bit_set(const void *token, int fn_bit)
 	       addr[fn_bit >> 5];
 }

Perhaps all the __inline__ uses could be changed to inline too.

Or rather, deleted completely, this is a *.c file after all.

Maybe right.  There are a lot though just in net/

$ git ls-files net | grep "\.c$" | \
  xargs grep -Pw "_{0,2}inline_{0,2}" | wc -l
1512

Or change to inline and move the whole function to ip6_fib.h?

No, that is not desirable.  The whole point is to not export the interface
outside of the *.c file, and to let the compiler make inlining decisions
since it can see all of the call sites.