Re: [PATCH net-next v2 3/3] ipv6: fix checkpatch errors of "foo*" and "foo * bar"
From: Hannes Frederic Sowa <hidden>
Date: 2014-03-28 10:17:06
From: Hannes Frederic Sowa <hidden>
Date: 2014-03-28 10:17:06
On Fri, Mar 28, 2014 at 01:40:12AM -0400, David Miller wrote:
From: Joe Perches <joe@perches.com> Date: Thu, 27 Mar 2014 21:22:01 -0700quoted
On Fri, 2014-03-28 at 12:07 +0800, Wangyufen wrote: []quoted
diff --git a/net/ipv6/ip6_fib.c b/net/ipv6/ip6_fib.c[]quoted
@@ -143,7 +143,7 @@ static __inline__ __be32 addr_bit_set(const void *token, int fn_bit) addr[fn_bit >> 5]; }Perhaps all the __inline__ uses could be changed to inline too.Or rather, deleted completely, this is a *.c file after all.
Smart-arsing: Removing inline keyword makes the function visible to tracing if it didn't get inlined. I think this is a nice side-effect because debug kernels are often compiled with less aggressive inlining options (readable asm kconfig option).