RE: [PATCH net-next 12/14] r8152: replace netif_rxwithnetif_receive_skb

 Francois Romieu [mailto:romieu@fr.zoreil.com] 

Sent: Wednesday, February 19, 2014 3:47 PM
To: hayeswang
Cc: netdev@vger.kernel.org; nic_swsd@realtek.com; 
linux-kernel@vger.kernel.org; linux-usb@vger.kernel.org
Subject: Re: [PATCH net-next 12/14] r8152: replace 
netif_rxwithnetif_receive_skb

[...]

The change in rx_bottom is fine. My point is about read_bulk_callback.

rx_bottom races with read_bulk_callback. rx_bottom is issued in
tasklet (softirq) context. read_bulk_callback is issued in irq
context, with irq disabled. read_bulk_callback does not need to
disable irq itself and could go with spin_lock in place of
spin_lock_irqsave (rx_bottom can't, of course).

I think I misunderstand your meaning.
I would modify them. Thanks.
 
Best Regards,
Hayes