RE: [PATCH net-next 12/14] r8152: replace netif_rx withnetif_receive_skb

 Francois Romieu [mailto:romieu@fr.zoreil.com] 

Sent: Wednesday, February 19, 2014 7:29 AM
To: Hayes Wang
Cc: netdev@vger.kernel.org; nic_swsd@realtek.com; 
linux-kernel@vger.kernel.org; linux-usb@vger.kernel.org
Subject: Re: [PATCH net-next 12/14] r8152: replace netif_rx 
withnetif_receive_skb

Hayes Wang [off-list ref] :

quoted

Replace netif_rx with netif_receive_skb to avoid disabling irq frequently
for increasing the efficiency.

read_bulk_callback is issued in irq context. It could thus use plain
spin_lock / spin_unlock instead of the irq disabling version.

The rx_bottom() is called in tasklet, so I just think I could use
netif_receive_skb directly. The netif_rx seems to queue the packet,
and local_irq_disable() would be called before dequeuing the skb.
 
Best Regards,
Hayes