Re: [PATCH 1/1] Per socket value for max datagram queue length
From: Eric Dumazet <hidden>
Date: 2014-01-22 15:30:21
Also in:
linux-arch, lkml
On Wed, 2014-01-22 at 07:11 -0800, Dan Ballard wrote:
Provides a new option for setsockopt SO_MAX_DGRAM_QLEN that sets and gets a socket specific max datagram queue length. Currently each socket has one but it's only ever initialized from /proc/sys/net/unix/max_dgram_qlen and then never adjustable later. Now each socket can have it individually tweaked during it's life.
Your patch suffers from many problems. It breaks listen() It doesn't compile on a lot of arches. sk_max_ack_backlog is an unsigned short. max_dgram_qlen is used, but only for Unix sockets at this time Try : "git grep -n max_dgram_qlen" for details
quoted hunk ↗ jump to hunk
Signed-off-by: Dan Ballard <redacted> --- include/uapi/asm-generic/socket.h | 2 ++ net/core/sock.c | 7 +++++++ 2 files changed, 9 insertions(+)diff --git a/include/uapi/asm-generic/socket.hb/include/uapi/asm-generic/socket.h index 38f14d0..f8c3e6b 100644--- a/include/uapi/asm-generic/socket.h +++ b/include/uapi/asm-generic/socket.h@@ -80,4 +80,6 @@ #define SO_MAX_PACING_RATE 47 +#define SO_MAX_DGRAM_QLEN 48 + #endif /* __ASM_GENERIC_SOCKET_H */diff --git a/net/core/sock.c b/net/core/sock.c index 5393b4b..1ff69d1 100644 --- a/net/core/sock.c +++ b/net/core/sock.c@@ -915,6 +915,10 @@ set_rcvbuf: sk->sk_max_pacing_rate); break; + case SO_MAX_DGRAM_QLEN: + sk->sk_max_ack_backlog = val; + break; + default: ret = -ENOPROTOOPT; break;@@ -1182,6 +1186,9 @@ int sock_getsockopt(struct socket *sock, intlevel, int optname, v.val = sk->sk_max_pacing_rate; break; + case SO_MAX_DGRAM_QLEN: + v.val = sk->sk_max_ack_backlog; + break; default: return -ENOPROTOOPT; }