Thread (5 messages) 5 messages, 4 authors, 2014-01-22

Re: [PATCH 1/1] Per socket value for max datagram queue length

From: Hannes Frederic Sowa <hidden>
Date: 2014-01-22 15:20:39
Also in: linux-arch, lkml

On Wed, Jan 22, 2014 at 07:11:20AM -0800, Dan Ballard wrote:
quoted hunk ↗ jump to hunk
diff --git a/net/core/sock.c b/net/core/sock.c
index 5393b4b..1ff69d1 100644
--- a/net/core/sock.c
+++ b/net/core/sock.c
@@ -915,6 +915,10 @@ set_rcvbuf:
                                         sk->sk_max_pacing_rate);
                break;

+       case SO_MAX_DGRAM_QLEN:
+               sk->sk_max_ack_backlog = val;
+               break;
+
Shouldn't the backlog be capped for unprivileged users to some configurable
value? I even think that max_dgram_qlen should be the upper bound.

I guess it is not that serious as socket read accounting does account all
packets which sit in the backlog queue.

Greetings,

  Hannes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help