Re: [PATCH 01/23] netfilter: nft_reject: fix compilation warning if NF_TABLES_IPV6 is disabled

From: Sergei Shtylyov <redacted>
Date: Fri, 10 Jan 2014 23:33:22 +0300

Hello.

On 01/10/2014 03:35 AM, Pablo Neira Ayuso wrote:

quoted

net/netfilter/nft_reject.c: In function 'nft_reject_eval':
net/netfilter/nft_reject.c:37:14: warning: unused variable 'net'
[-Wunused-variable]

quoted

Reported-by: kbuild test robot <redacted>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---
  net/netfilter/nft_reject.c |    3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

quoted

diff --git a/net/netfilter/nft_reject.c b/net/netfilter/nft_reject.c
index 0d690d4..7ae63cd 100644
--- a/net/netfilter/nft_reject.c
+++ b/net/netfilter/nft_reject.c

@@ -34,8 +34,9 @@ static void nft_reject_eval(const struct nft_expr

*expr,
  			      const struct nft_pktinfo *pkt)
  {
  	struct nft_reject *priv = nft_expr_priv(expr);
+#if IS_ENABLED(CONFIG_NF_TABLES_IPV6)
  	struct net *net = dev_net((pkt->in != NULL) ? pkt->in : pkt->out);
-

   Why remove empty line after the declaration block?

Because "#endif" sort of serves the same purpose.

This is what I do too in this situation.