Re: [PATCH 01/23] netfilter: nft_reject: fix compilation warning if NF_TABLES_IPV6 is disabled
From: Sergei Shtylyov <hidden>
Date: 2014-01-10 20:33:22
Also in:
netfilter-devel
Hello. On 01/10/2014 03:35 AM, Pablo Neira Ayuso wrote:
net/netfilter/nft_reject.c: In function 'nft_reject_eval': net/netfilter/nft_reject.c:37:14: warning: unused variable 'net' [-Wunused-variable]
Reported-by: kbuild test robot <redacted> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org> --- net/netfilter/nft_reject.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
quoted hunk ↗ jump to hunk
diff --git a/net/netfilter/nft_reject.c b/net/netfilter/nft_reject.c index 0d690d4..7ae63cd 100644 --- a/net/netfilter/nft_reject.c +++ b/net/netfilter/nft_reject.c@@ -34,8 +34,9 @@ static void nft_reject_eval(const struct nft_expr *expr, const struct nft_pktinfo *pkt) { struct nft_reject *priv = nft_expr_priv(expr); +#if IS_ENABLED(CONFIG_NF_TABLES_IPV6) struct net *net = dev_net((pkt->in != NULL) ? pkt->in : pkt->out); -
Why remove empty line after the declaration block?
+#endif
switch (priv->type) {
case NFT_REJECT_ICMP_UNREACH:
if (priv->family == NFPROTO_IPV4)WBR, Sergei