RE: [net-next 05/16] i40e: fix long lines

-----Original Message-----
From: Joe Perches [mailto:joe@perches.com]
Sent: Friday, January 10, 2014 10:15 AM
To: Williams, Mitch A
Cc: David Laight; Kirsher, Jeffrey T; davem@davemloft.net;
netdev@vger.kernel.org; gospo@redhat.com; sassmann@redhat.com; Brandeburg,
Jesse
Subject: Re: [net-next 05/16] i40e: fix long lines

On Fri, 2014-01-10 at 18:05 +0000, Williams, Mitch A wrote:

quoted

quoted

-----Original Message-----
From: Joe Perches [mailto:joe@perches.com]
Sent: Friday, January 10, 2014 2:36 AM

[]

quoted

quoted

On Fri, 2014-01-10 at 10:02 +0000, David Laight wrote:

quoted

quoted

Another way this could be changed is to put the
return value on a separate line like:

i40e_status
i40e_aq_set_vsi_unicast_promiscuous(struct i40e_hw *hw, u16 seid,

bool

quoted

quoted

set,

quoted

quoted

				    struct i40e_asq_cmd_details *cmd_details)

Personally I prefer that so I can find the definition by grepping
for '^function_name' - but it doesn't seem to be done in any linux
source files.

That form is used in a lot of files.
$ git grep -E "^[a-z_]+\("

So, Joe, I just want to be clear. Is this a NAK, or just an FYI?

Hi Mitch.

This is your/intel's code.  I don't/shouldn't nak it.
I made a simple suggestion of an alternate style.

quoted

If it's a serious issue for you (or Dave), we'll fix it right away.

It's up to you all to fix it (or not) as you chose.
It's trivial to me.

cheers, Joe

Thanks, Joe. As long as Dave is OK with it, I'll let it stand as-is and scrub the whole driver later for stuff like this.

BTW, I appreciate all the time you spend looking at our code. We've got a decent sized team here, but it's always good to have somebody outside the organization keeping us honest.

-Mitch