Re: [PATCH net-next V2 1/3] net: Add GRO support for UDP encapsulating protocols

On 09/01/2014 05:12, Jerry Chu wrote:

quoted

quoted

quoted

quoted

Also "udp_offload" is a little misleading - you are not trying to GRO UDP
pkts where UDP is the real transport. You are only trying to GRO UDP
encapped TCP pkts.

Indeed -- however, I just plugged into what was there for GSO, e.g stack
will not do GSO for plain UDP
packets, only for those who encapsulate something the code that does this is
udp_offloads.c -- any suggestion
how to phrase/frame the change you envision?

There is already udpv4_offload for real udp gso (ufo) offload. How about "udp_encap_offload" for your stuff?

well, I don't see how it can work... the problem with your suggestion is 
that we'll have two structures to compete on the UDP protocol entry in 
the inet offloads structure, one that holds the current udp gso offloads 
and one with the udp gro offloads.