Thread (34 messages) flat view 34 messages, 6 authors, 2014-01-09

Re: [PATCH net-next V2 1/3] net: Add GRO support for UDP encapsulating protocols

From: Tom Herbert <hidden>
Date: 2014-01-08 16:29:48

Tom,

OK, so I understand that you want the infrastructure to allow for direct udp
encapsulation in the sense that there is no specific encapsulation header
following the udp header.

Take for example encapsulating TCP over UDP port X, the layer/driver that
wants to enable gro for such traffic will register a udp gro handler for
port X and in their gro receive/complete
callbacks would just assume that following the UDP header there's TCP header
and they will then issue a lookup in the inet gro handlers array to get the
TCP gro handler, problem solved, agree?
Yes, that could work, but except for specifying a different protocol
number, the code to do direct encapsulation with GRO would be
identical for TCP/UDP, GRE/UDP, IPIP/UDP, ... we should be able to
avoid redundancy.  Let's get the basic UDP GRO support in, and then I
think adding support for direct encapsulation can be done without API
change in your proposed scheme.
Or.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help