Re: [PATCH] sh_eth: coding style fixes
From: Joe Perches <joe@perches.com>
Date: 2014-01-03 01:42:36
Also in:
linux-sh
From: Joe Perches <joe@perches.com>
Date: 2014-01-03 01:42:36
Also in:
linux-sh
On Thu, 2014-01-02 at 19:34 -0500, David Miller wrote:
From: Sergei Shtylyov <redacted> Date: Tue, 31 Dec 2013 03:25:21 +0300quoted
@@ -1952,8 +1949,8 @@ static void sh_eth_tx_timeout(struct net netif_stop_queue(ndev); if (netif_msg_timer(mdp)) - dev_err(&ndev->dev, "%s: transmit timed out, status %8.8x," - " resetting...\n", ndev->name, (int)sh_eth_read(ndev, EESR)); + dev_err(&ndev->dev, "%s: transmit timed out, status %8.8x, resetting...\n" + ndev->name, (int)sh_eth_read(ndev, EESR)); /* tx_errors count up */ ndev->stats.tx_errors++;You did not build test this. drivers/net/ethernet/renesas/sh_eth.c: In function ‘sh_eth_tx_timeout’: drivers/net/ethernet/renesas/sh_eth.c:1953:4: error: expected ‘)’ before ‘ndev’
Also, this would likely be better as: netif_err(mdp, timer, ndev, "transmit timed out, status %#08lx, resetting...\n", sh_eth_read(ndev, EESR));