Re: [PATCH] sh_eth: coding style fixes
From: David Miller <davem@davemloft.net>
Date: 2014-01-03 00:34:07
Also in:
linux-sh
From: Sergei Shtylyov <redacted> Date: Tue, 31 Dec 2013 03:25:21 +0300
quoted hunk ↗ jump to hunk
@@ -1952,8 +1949,8 @@ static void sh_eth_tx_timeout(struct net netif_stop_queue(ndev); if (netif_msg_timer(mdp)) - dev_err(&ndev->dev, "%s: transmit timed out, status %8.8x," - " resetting...\n", ndev->name, (int)sh_eth_read(ndev, EESR)); + dev_err(&ndev->dev, "%s: transmit timed out, status %8.8x, resetting...\n" + ndev->name, (int)sh_eth_read(ndev, EESR)); /* tx_errors count up */ ndev->stats.tx_errors++;
You did not build test this. drivers/net/ethernet/renesas/sh_eth.c: In function ‘sh_eth_tx_timeout’: drivers/net/ethernet/renesas/sh_eth.c:1953:4: error: expected ‘)’ before ‘ndev’ drivers/net/ethernet/renesas/sh_eth.c:1953:4: warning: format ‘%s’ expects a matching ‘char *’ argument [-Wformat] drivers/net/ethernet/renesas/sh_eth.c:1953:4: warning: format ‘%x’ expects a matching ‘unsigned int’ argument [-Wformat]