Re: [net-next bugfix] net, rps: fix build failure when CONFIG_RPS isn't set
From: David Miller <davem@davemloft.net>
Date: 2013-12-31 20:55:04
From: Zhi Yong Wu <redacted> Date: Wed, 1 Jan 2014 04:31:01 +0800
quoted hunk ↗ jump to hunk
@@ -846,12 +846,16 @@ static inline void sock_rps_reset_flow_hash(__u32 hash) static inline void sock_rps_record_flow(const struct sock *sk) { +#ifdef CONFIG_RPS sock_rps_record_flow_hash(sk->sk_rxhash); +#endif }
Why is this necessary? sock_rps_record_flow_hash() is provided unconditionally, regardless of CONFIG_RPS. I'm not applying this, it doesn't make any sense. Either there is no build failure, or the existing CONFIG_RPS ifdef inside of the implementation of sock_rps_record_flow_hash() is bogus.