Thread (7 messages) flat view 7 messages, 3 authors, 2013-11-08

Re: [patch] net: make ndev->irq signed for error handling

From: David Miller <davem@davemloft.net>
Date: 2013-11-08 00:14:00
Also in: kernel-janitors, lkml

From: Dan Carpenter <redacted>
Date: Thu, 7 Nov 2013 10:48:49 +0300
There is a bug in cpsw_probe() where we do:

	ndev->irq = platform_get_irq(pdev, 0);
	if (ndev->irq < 0) {

The problem is that "ndev->irq" is unsigned so the error handling
doesn't work.  I have changed it to a regular int.

Signed-off-by: Dan Carpenter <redacted>
Even though some simplifications have been suggested wrt. how
this irq value is obtained in the one place where it is used,
I am applying Dan's patch for now.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help