Thread (7 messages) flat view 7 messages, 3 authors, 2013-11-08

Re: [patch] net: make ndev->irq signed for error handling

From: Mugunthan V N <hidden>
Date: 2013-11-07 12:14:48
Also in: kernel-janitors, lkml

On Thursday 07 November 2013 01:18 PM, Dan Carpenter wrote:
There is a bug in cpsw_probe() where we do:

	ndev->irq = platform_get_irq(pdev, 0);
	if (ndev->irq < 0) {

The problem is that "ndev->irq" is unsigned so the error handling
doesn't work.  I have changed it to a regular int.

Signed-off-by: Dan Carpenter <redacted>
ndev->irq is never used any where in the driver, I think its better to
remove this part of code from probe. If every one is ok, I can send a
patch to remove the code.

Regards
Mugunthan V N
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help