Re: [PATCH 0/9] genetlink: reduce ops size and complexity (v2)

From
Johannes Berg <johannes@sipsolutions.net>
Date
2013-11-17 09:12:10
Also in
netfilter-devel
Reply to
David Miller, 2013-11-16
On Fri, 2013-11-15 at 20:53 -0500, David Miller wrote:
quoted
We could instead register an array of pointers to the groups:

static const struct mcast_group *my_groups[] = {
      &my_foo_mcast_group,
      ...
};

and pass this to the family - that'd still be less space (one pointer
for each group rather than two in a linked list) and still allow all
groups and this array to be const, but it's not quite as big a
saving ...

Thoughts?
This idea sounds fine.  I don't even thing the array indexing is
odd, especially if we can have named mnenomics for the indices
or similar.
I posted something yesterday, but forgot to reply here - basically as
you'll see in the patches, I decided that we should pass the
family/group array index instead of passing the global group identifier
- this will also prevent new users of the APIs from abusing them like
quota/dropmonitor unfortunately did.

johannes
Thread (29 messages) 29 messages, 3 authors, last reply 2013-11-17
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help