Re: [PATCH 0/9] genetlink: reduce ops size and complexity (v2)

From
Johannes Berg <johannes@sipsolutions.net>
Date
2013-11-15 13:23:14
Also in
netfilter-devel
Reply to
Johannes Berg, 2013-11-15
On Fri, 2013-11-15 at 14:18 +0100, Johannes Berg wrote:
I've been eyeing the multicast groups as well
Of course, there are also *much* fewer mcast groups, so the saving isn't
nearly as big. But we still have some oddball code to register them all,
basically

	err = register_mc_group();
	if (err)
		goto unregister_family;

(since we have to register the family first, afaict)

sometimes a few of those back to back, and it'd be nicer on the users if
that just went away and was

	family.mcast_groups = my_groups;
	family.n_mcast_groups = ARRAY_SIZE(my_groups);
	family.ops = my_ops;
	family.n_ops = ARRAY_SIZE(my_ops);
	return genl_register_family(&family);

since nobody uses them dynamically anyway, afaict.

johannes
Thread (29 messages) 29 messages, 3 authors, last reply 2013-11-17
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help