Re: [PATCH 1/3] vxlan: silence one build warning

On Mon, 28 Oct 2013 00:38:07 -0400 (EDT)
David Miller [off-list ref] wrote:

From: Stephen Hemminger <stephen@networkplumber.org>
Date: Fri, 25 Oct 2013 08:41:34 -0700

quoted

I would rather not fix the warning this way since it risks masking
later bugs if this code ever changes.

But this is suboptimally coded, and is asking for the warning.

Anything returning a pointer by reference is asking for trouble
in my opinion.

The correct thing to do is to make create_v{4,6}_sock() return
the "struct socket *" as an error pointer.

No more ambiguous initializations, no more warnings.

Agreed, original code used ERR_PTR (see vxlan_socket_create),
the side effect stuff only came with the addition of IPv6.