Re: [PATCH 1/3] vxlan: silence one build warning
From: Stephen Hemminger <stephen@networkplumber.org>
Date: 2013-10-25 15:41:44
Also in:
lkml
On Fri, 25 Oct 2013 15:49:18 +0800 Zhi Yong Wu [off-list ref] wrote:
quoted hunk ↗ jump to hunk
From: Zhi Yong Wu <redacted> drivers/net/vxlan.c: In function ‘vxlan_sock_add’: drivers/net/vxlan.c:2298:11: warning: ‘sock’ may be used uninitialized in this function [-Wmaybe-uninitialized] drivers/net/vxlan.c:2275:17: note: ‘sock’ was declared here LD drivers/net/built-in.o Signed-off-by: Zhi Yong Wu <redacted> --- drivers/net/vxlan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index 2ef5b62..e15f1af 100644 --- a/drivers/net/vxlan.c +++ b/drivers/net/vxlan.c@@ -2272,7 +2272,7 @@ static struct vxlan_sock *vxlan_socket_create(struct net *net, __be16 port, { struct vxlan_net *vn = net_generic(net, vxlan_net_id); struct vxlan_sock *vs; - struct socket *sock; + struct socket *sock = NULL; struct sock *sk; int rc = 0; unsigned int h;
This only happens with certain versions of Gcc which have buggy dependency analysis. It doesn't happen with Gcc 4.7, think it only shows up in 4.4. I would rather not fix the warning this way since it risks masking later bugs if this code ever changes.