Re: [PATCH] net: secure_seq: Move net_secret_init() definition into CONFIG_IPV6 if block

On Sat, Oct 5, 2013 at 1:27 PM, David Miller [off-list ref] wrote:

From: Fabio Estevam <festevam@gmail.com>
Date: Sat,  5 Oct 2013 17:09:50 -0300

quoted

From: Fabio Estevam <redacted>

Commit 9a3bab6b05 (net: net_secret should not depend on TCP) introduced
the following build warning when CONFIG_IPV6 is not selected:

net/core/secure_seq.c:17:13: warning: 'net_secret_init' defined but not used [-Wunused-function]

Fix it by moving net_secret_init(void) inside the '#if IS_ENABLED(CONFIG_IPV6)'
block.

Reported-by: Olof Johansson <redacted>
Signed-off-by: Fabio Estevam <redacted>

seq_scale is used by secure_tcp_sequence_number, which is only protected
by CONFIG_INET.  I have no idea how you can get this build problem.

And I cannot reproduce it here:

You get it if you have CONFIG_NET enabled, but CONFIG_INET off. We
seem to have a few defconfigs on arm that has that setting, likely
because they lack native network interfaces but need local unix
sockets. Or whatever. But that's how you hit it.

Steps to reproduce, even with ARCH=sparc:

make allnoconfig
edit .config, set CONFIG_NET=y
yes "" | make oldconfig
make


-Olof