Re: [PATCH] net: secure_seq: Move net_secret_init() definition into CONFIG_IPV6 if block

From: Fabio Estevam <festevam@gmail.com>
Date: Sat,  5 Oct 2013 17:09:50 -0300

From: Fabio Estevam <redacted>

Commit 9a3bab6b05 (net: net_secret should not depend on TCP) introduced
the following build warning when CONFIG_IPV6 is not selected:

net/core/secure_seq.c:17:13: warning: 'net_secret_init' defined but not used [-Wunused-function]

Fix it by moving net_secret_init(void) inside the '#if IS_ENABLED(CONFIG_IPV6)'
block.

Reported-by: Olof Johansson <redacted>
Signed-off-by: Fabio Estevam <redacted>

seq_scale is used by secure_tcp_sequence_number, which is only protected
by CONFIG_INET.  I have no idea how you can get this build problem.

And I cannot reproduce it here:

[davem@drr net]$ egrep CONFIG_IPV6 .config
# CONFIG_IPV6 is not set
[davem@drr net]$ make net/core/secure_seq.o
scripts/kconfig/conf --silentoldconfig Kconfig
make[1]: Nothing to be done for `all'.
make[1]: Nothing to be done for `relocs'.
  CHK     include/config/kernel.release
  CHK     include/generated/uapi/linux/version.h
  CHK     include/generated/utsrelease.h
  CALL    scripts/checksyscalls.sh
  CC      net/core/secure_seq.o
[davem@drr net]$ 

Furthermore your commit message is talking about net_secret_init but
your patch does things with seq_scale.

I'm not applying this patch.