RE: [PATCH net-next v4] Don't destroy the netdev until the vif is shut down
From: Paul Durrant <hidden>
Date: 2013-09-20 08:10:27
-----Original Message----- From: David Miller [mailto:davem@davemloft.net] Sent: 19 September 2013 19:05 To: Paul Durrant Cc: xen-devel@lists.xen.org; netdev@vger.kernel.org; David Vrabel; Wei Liu; Ian Campbell Subject: Re: [PATCH net-next v4] Don't destroy the netdev until the vif is shut down From: Paul Durrant <redacted> Date: Tue, 17 Sep 2013 17:46:08 +0100quoted
Without this patch, if a frontend cycles through states Closing and Closed (which Windows frontends need to do) then the netdev will be destroyed and requires re-invocation of hotplug scripts to restore state before the frontend can move to Connected. Thus when udev is not in use the backend gets stuck in InitWait. With this patch, the netdev is left alone whilst the backend is still online and is only de-registered and freed just prior to destroying the vif (which is also nicely symmetrical with the netdev allocation and registration being done during probe) so no re-invocation of hotplug scripts is required. Signed-off-by: Paul Durrant <redacted>I think all of the testing requests have been satisfied so I have applied this. But _please_ write a more proper subject line in future patch submissions. You have to provide a subsystem prefix in the subject line, here I added "xen-netback: ", otherwise someone skimming the shortlog has no idea what area of code this change touches.
Ok. Will do. Thanks, Paul